Solution #1329
Open
Solution #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlopro
suggested changes
Oct 2, 2024
app/main.py
Outdated
|
|
||
| @wraps(func) | ||
| def wrapper(*args) -> Any: | ||
| if args in cache_store: |
There was a problem hiding this comment.
**kwargs and function name should be included as well
There was a problem hiding this comment.
I have added **kwargs, what did you mean by "function name"?
app/main.py
Outdated
| if args in cache_store: | ||
| print("Getting from cache") | ||
| return cache_store[args] | ||
| else: |
pavlopro
suggested changes
Oct 6, 2024
tests/test_main.py
Outdated
| @@ -171,6 +171,42 @@ def delay_addition(a, b): | |||
| assert time3 - time2 < 1, "Cache decorator should return cached value." | |||
|
|
|||
|
|
|||
| def test_use_named_arguments(): | |||
There was a problem hiding this comment.
Please do not modify tests folder. All changes should be done in main.py
app/main.py
Outdated
|
|
||
| @wraps(func) | ||
| def wrapper(*args, **kwargs) -> Any: | ||
| cache_key = f"{args}, {kwargs}" |
There was a problem hiding this comment.
include funtion name into cache_key as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.