Solution #1334
Open
Solution #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsmutok
suggested changes
Oct 6, 2024
app/main.py
Outdated
Comment on lines
13
to
22
| else: | ||
| print("Calculating new result") | ||
| result = func(*args) | ||
| save_result[(func, args,)] = result | ||
| return result | ||
| else: | ||
| print("Calculating new result") | ||
| result = func(*args) | ||
| save_result[(func, args,)] = result | ||
| return result |
app/main.py
Outdated
Comment on lines
7
to
9
| def inner(*args) -> Callable: | ||
| if save_result: | ||
| key_in_save_result = (func, args,) |
app/main.py
Outdated
|
|
||
| def inner(*args) -> Callable: | ||
| if save_result: | ||
| key_in_save_result = (func, args,) |
There was a problem hiding this comment.
Suggested change
| key_in_save_result = (func, args,) | |
| key_in_save_result = (func.__name__, args,) |
vsmutok
suggested changes
Oct 6, 2024
app/main.py
Outdated
Comment on lines
8
to
14
| key_in_save_result = (func.__name__, args,) | ||
| for value in kwargs.values(): | ||
| key_in_save_result.add(value) | ||
| if save_result: | ||
| if key_in_save_result in save_result: | ||
| print("Getting from cache") | ||
| return save_result[key_in_save_result] |
There was a problem hiding this comment.
Suggested change
| key_in_save_result = (func.__name__, args,) | |
| for value in kwargs.values(): | |
| key_in_save_result.add(value) | |
| if save_result: | |
| if key_in_save_result in save_result: | |
| print("Getting from cache") | |
| return save_result[key_in_save_result] | |
| key = (func.__name__, args, tuple(kwargs.items())) | |
| if key in save_result: | |
| print("Getting from cache") | |
| return save_result[key_in_save_result] |
app/main.py
Outdated
Comment on lines
16
to
19
| print("Calculating new result") | ||
| result = func(*args) | ||
| save_result[key_in_save_result] = result | ||
| return result |
There was a problem hiding this comment.
Suggested change
| print("Calculating new result") | |
| result = func(*args) | |
| save_result[key_in_save_result] = result | |
| return result | |
| print("Calculating new result") | |
| result = func(*args, **kwargs) | |
| save_result[key_in_save_result] = result | |
| return result |
vsmutok
suggested changes
Oct 6, 2024
app/main.py
Outdated
|
|
||
| def inner(*args, **kwargs) -> Callable: | ||
| key_in_save_result = (func.__name__, args, tuple(kwargs.items())) | ||
| if save_result: |
There was a problem hiding this comment.
this check is redundant here
vsmutok
approved these changes
Oct 7, 2024
Comment on lines
+6
to
+7
|
|
||
| def inner(*args, **kwargs) -> Callable: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.