Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1351

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

solution #1351

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd44ce1
solution
serhiik05 Oct 18, 2024
fcc3d46
solution
serhiik05 Oct 18, 2024
f83fbb5
solution
serhiik05 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
from typing import Callable
from typing import Callable, Any


def cache(func: Callable) -> Callable:
# Write your code here
pass
func_cache = {}

def wrapper(*args) -> Any:
if args in func_cache:
print("Getting from cache")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using mutable types like lists or dictionaries as keys in a dictionary will raise a TypeError because they are not hashable. Consider using only immutable types like tuples as keys, or converting the arguments to a hashable type before using them as keys.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using args as a dictionary key can lead to issues if args contains mutable types like lists. Consider converting args to a hashable type, such as a tuple of tuples, to ensure it can be used as a dictionary key.

return func_cache[args]
else:
print("Calculating new result")
result = func(*args)
func_cache[args] = result
return result
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the arguments used as keys in the dictionary are immutable. If the function can receive mutable arguments, consider converting them to a hashable type before storing them in the cache.


return wrapper
Loading