Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1354

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Solution #1354

wants to merge 5 commits into from

Conversation

IrynaBrenko
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type of long_time_func_2 needs to be corrected to match its actual return value. Please update the return type annotation to reflect that the function returns a list. Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/main.py Outdated Show resolved Hide resolved
@IrynaBrenko
Copy link
Author

Можна підтвердити моє завдання?

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the caching decorator function! 🎉 The code is efficient, follows the DRY principle, and has consistent style with descriptive variable names. While there are no unnecessary comments or print statements, make sure to review any feedback provided to further enhance your code quality. Remember, addressing any critical issues in the future will help you grow as a developer. Keep up the good work and continue learning from each experience! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants