ready #1356
ready #1356
Conversation
There was a problem hiding this comment.
Great job on the implementation! 🎉 While there are a couple of minor typos and an opportunity to optimize the loop for efficiency, these don't critically impact the functionality. Keep up the good work and consider these improvements for future projects!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| # Write your code here | ||
| pass | ||
| cache_args = {} | ||
| resalt_func = {} |
There was a problem hiding this comment.
There is a typo in the variable name resalt_func. It should be result_func to be more descriptive and correct.
|
|
||
| if args not in cache_args: | ||
| cache_args[i[0]] = args | ||
| resalt = func(*args) |
There was a problem hiding this comment.
There is a typo in the variable name resalt. It should be result to be more descriptive and correct.
| for key, value in cache_args.items(): | ||
| if value == args: | ||
| args_key = key | ||
| return resalt_func[args_key] |
There was a problem hiding this comment.
The loop to find args_key is inefficient. Consider storing the result directly in the cache with args as the key instead of using an index. This will simplify the retrieval process and improve efficiency.
with args cache