Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
359c6cd
Solution
RadeonT800 Oct 31, 2024
1ea88dd
Check immutable
RadeonT800 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,24 @@
from typing import Callable
from typing import Callable, Any
import functools


def cache(func: Callable) -> Callable:
# Write your code here
pass
calculated_data = []

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calculated_data variable should be a list of tuples, which it is, but it should be initialized as an empty list. This is correct, but ensure that the logic of storing and retrieving cached data is handled properly.

@functools.wraps(func)
def wrapper(*args, **kwargs) -> Any:
for value in args:
if isinstance(value, (list, set, dict)):
return None
for value in kwargs.values():
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning None when encountering a list, set, or dict in args might not be the best approach. Consider raising an exception or handling this case differently to avoid unexpected behavior.

if isinstance(value, (list, set, dict)):
return None
for args_save, kwargs_save, result_save in calculated_data:
if args_save == args and kwargs_save == kwargs:
print("Getting from cache")
return result_save
result = func(*args, **kwargs)
calculated_data.append((args, kwargs, result))
print("Calculating new result")
RadeonT800 marked this conversation as resolved.
Show resolved Hide resolved
return result
return wrapper
Loading