Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'solution' #1387

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,16 @@


def cache(func: Callable) -> Callable:
# Write your code here
pass
cached_data = {}

def wrapper(*args, **kwargs) -> Callable:
parameters = tuple(args)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you can't do without tuple?

if parameters not in cached_data.keys():
result = func(*args, **kwargs)
cached_data[parameters] = result
print("Calculating new result")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using additional variable, it is not needed here

return result
else:
print("Getting from cache")
return cached_data.get(parameters)
return wrapper

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always add a blank line at the end of the file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, sure, but it is there (flake8 always push me to do this)

Loading