Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1394

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,31 @@
from typing import Callable
from typing import Callable, Any


def cache(func: Callable) -> Callable:
# Write your code here
pass
cache_dict = {}

def wrapper(*args, **kwargs) -> Any:
flag = True
while flag:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this flag variable

data_iterable = tuple(
[item for item in args if isinstance(item, (int, str, float))]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include kwargs as well

)
if data_iterable not in cache_dict:
print("Calculating new result")
cache_dict[data_iterable] = func(*args, **kwargs)
return cache_dict[data_iterable]
else:
print("Getting from cache")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else operator is redundant. remove it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I delete else how can I get the cached element back?

return cache_dict[data_iterable]

return wrapper


@cache
def long_time_func(a: int, b: int, c: int) -> int: # NOQA VNE001
return (a ** b ** c) % (a * c)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove those examples from PR


@cache
def long_time_func_2(n_tuple: tuple, power: int) -> list:
return [number ** power for number in n_tuple]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The long_time_func_2 function is expected to return an int, but it currently returns a list. Please adjust the function to return an integer or update the return type annotation if a list is indeed the intended return type.

Loading