Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
from typing import Callable
from typing import Callable, Any


def cache(func: Callable) -> Callable:
# Write your code here
pass
def cache(func: callable) -> Callable:
cache_result = {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for func should be Callable with a capital 'C'. The correct import from typing is Callable, not callable.


def function_cache(*args) -> Any:
if args not in cache_result:
cache_result[*args] = func(*args)
print("Calculating new result")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax cache_result[*args] is incorrect for dictionary key assignment. It should be cache_result[args] since args is already a tuple.

else:
print("Getting from cache")
return cache_result[*args]
return function_cache

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, use cache_result[args] instead of cache_result[*args] to access the cached result.

Loading