Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1410

wants to merge 1 commit into from

Conversation

JurassicGen
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the caching decorator! 🎉 The code meets all the task requirements and constraints, ensuring efficient caching functionality. While there's a minor issue with the return type annotation of the inner function, it doesn't impact the overall functionality. Consider using Any for the return type to better match the decorated function's return type. Keep up the excellent work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

pass
cache_storage: Dict[Tuple, Any] = {}

def inner(*args, **kwargs) -> Callable:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type annotation for the inner function should not be Callable. Since inner is a wrapper function that returns the result of func, its return type should match the return type of func. You can use Any as a return type to accommodate any return type from func.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants