Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

liliia-kostenko
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the caching decorator! 🎉 The code meets the task requirements effectively, and the functionality is correct. While there's a minor issue with the return type hint of the inner function, it doesn't impact the functionality. Keep up the good work and consider updating the type hint to enhance code clarity in the future. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

pass
cache_dict = {}

def inner(*args, **kwargs) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inner function should return the same type as the func it wraps. Currently, it is defined to return None, which is incorrect. You should update the return type hint to match the return type of func, which is Callable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants