cache decorator #1420
cache decorator #1420
Conversation
valerii-kashpur
commented
Nov 27, 2024
valerii-kashpur
commented
- added chache
- added chache
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets the task requirements and constraints effectively. While the implementation is correct, consider converting args to a hashable type to avoid potential issues with mutable types as keys in the cache. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| def wrapper(*args, **kwargs) -> Callable: | ||
| nonlocal cache_storage | ||
| if args in cache_storage: |
There was a problem hiding this comment.
Using args as a key in cache_storage can lead to issues if args contains mutable types like lists. Consider converting args to a hashable type, such as a tuple of tuples, to ensure it can be used as a dictionary key.
| return cache_storage[args] | ||
| else: | ||
| func_result = func(*args, **kwargs) | ||
| cache_storage.update({args: func_result}) |
There was a problem hiding this comment.
Similar to the previous comment, ensure that args is converted to a hashable type before using it as a key in cache_storage.
