Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1425

wants to merge 1 commit into from

Conversation

kolya2731
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on implementing the cache decorator! 🎉 Your solution meets the task requirements effectively, and you've handled multiple functions and immutable arguments well. Just a friendly reminder: be cautious with mutable arguments as keys in the cache dictionary, as they can lead to unexpected behavior. Keep up the great work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

cache_dict = {}

def wrapper(*args: Any) -> Any:
if args in cache_dict:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using mutable types (like lists or dictionaries) as keys in a dictionary can lead to errors because they are not hashable. Consider ensuring that only hashable types are used as arguments, or convert mutable types to immutable ones (e.g., using tuples) before using them as keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants