Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,22 @@
from typing import Callable

from functools import wraps


def cache(func: Callable) -> Callable:
# Write your code here
pass
cash_dict = {}

@wraps(func)
def compare_cash(*args) -> dict:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type annotation -> dict for compare_cash is incorrect. It should match the return type of the function being decorated, which is Callable.

func_name = func.__name__

if (func_name, args) not in cash_dict:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using args directly as a dictionary key can lead to issues if args contains mutable types, such as lists. Consider converting args to a hashable type, like a tuple of tuples, to ensure it can be used as a dictionary key.

print("Calculating new result")
result = func(*args)
cash_dict[(func_name, args)] = result
return result
else:
print("Getting from cache")
return cash_dict[(func_name, args)]

return compare_cash