'Solution' #1433
Open
'Solution' #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L1nk3rrr
suggested changes
Dec 2, 2024
app/main.py
Outdated
| cache_data = {} | ||
|
|
||
| def wrapper(*args) -> Callable: | ||
| if args in cache_data.keys(): |
There was a problem hiding this comment.
Looks like calling keys() not needed, as we already checking at dict keys
app/main.py
Outdated
| pass | ||
| cache_data = {} | ||
|
|
||
| def wrapper(*args) -> Callable: |
There was a problem hiding this comment.
You can return not only callable, because your functions can return any type
There was a problem hiding this comment.
Many thanks for your correction. I got it. I understood why exactly so and for what
app/main.py
Outdated
Comment on lines
9
to
14
| print("Getting from cache") | ||
| return cache_data[args] | ||
|
|
||
| cache_data[args] = func(*args) | ||
| print("Calculating new result") | ||
| return cache_data[args] |
There was a problem hiding this comment.
You can try to simplify your solution to use only one return
L1nk3rrr
suggested changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.