Solution whith Any type #1440
Solution whith Any type #1440
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets the task requirements and handles multiple functions efficiently. Just a small note: be mindful of the cache key generation, as using non-hashable keyword arguments could lead to errors. Keep up the great work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| @wraps(func) | ||
| def wrapper(*args, **kwargs) -> Any: | ||
| cache_key = (args, tuple(sorted(kwargs.items()))) |
There was a problem hiding this comment.
The cache key is created using tuple(sorted(kwargs.items())), which assumes that all keyword arguments are hashable and that their order does not affect the result. If any of the keyword arguments are not hashable (e.g., lists or dictionaries), this will raise an error. Consider ensuring that all keyword arguments are hashable or converting them to a hashable type.
No description provided.