Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created decorator for task #1443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PavloDanylkiv
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your implementation of the caching decorator is well-done and meets the task requirements! 🎉 The functionality is correct, and the code is efficient and stylish. Just a small note: consider adjusting the return type hint for the inner function to match the return type of func, which could be Any or the specific type if known. Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

pass
result_dict = {}

def inner(*args, **kwargs) -> int:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type hint for the inner function is specified as int, which may not be accurate. Since the inner function returns the result of func, the return type should match the return type of func. Consider using Any or the same return type as func if known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants