Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1446

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #1446

wants to merge 2 commits into from

Conversation

Dmitriy527
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the caching decorator! 🎉 Your solution meets the task requirements and works well with multiple functions. Just a small note: be cautious with mutable arguments as dictionary keys, as they can lead to unexpected behavior. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


def wrapper(*args) -> int:

if args not in our_dict:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using args as a dictionary key assumes that all arguments are hashable. If any of the arguments are mutable (like lists), this will raise a TypeError. Consider ensuring that only hashable types are used as arguments or converting mutable types to immutable ones (e.g., using tuples).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants