Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
from typing import Callable
from typing import Callable, Any
from functools import wraps


def cache(func: Callable) -> Callable:
# Write your code here
pass
result = {}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result dictionary is defined at the function level, which means it will be shared across all instances of the decorated function. This is fine if the decorator is used on a single function, but if used on multiple functions, their results will be mixed. Consider using a more robust solution if the decorator is intended for multiple functions.

@wraps(func)
def wrapper(*args) -> Any:
if args not in result:
print("Calculating new result")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using args as a key in the dictionary assumes that all arguments are hashable. If the function accepts non-hashable arguments (like lists or dictionaries), this will raise a TypeError. Consider handling such cases or documenting that the decorator only works with hashable arguments.

result[args] = func(*args)
else:
print("Getting from cache")
return result[args]
return wrapper
Loading