Solution #1451
Open
Solution #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets all the task requirements and constraints effectively. The use of args not in my_cash is indeed more Pythonic and efficient, which is a nice touch. Keep up the excellent work, and continue to refine your skills with such attention to detail! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| my_cash = {} | ||
|
|
||
| def inner(*args) -> str: | ||
| if args not in my_cash.keys(): |
There was a problem hiding this comment.
Using args not in my_cash is sufficient and more Pythonic than args not in my_cash.keys(). The keys() method is unnecessary here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.