Solution #1453
Open
Solution #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 The functionality is spot on, and it meets all the task requirements. Just a small suggestion: consider updating the return type annotation of the wrapper function to Any to make it more flexible for various use cases. Keep up the fantastic work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
app/main.py
Outdated
| # Write your code here | ||
| pass | ||
| cache_func = {} | ||
| def wrapper(*args, **kwargs) -> str: |
There was a problem hiding this comment.
The return type annotation of the wrapper function is set to str, which may not be appropriate for all functions that this decorator could be applied to. Consider changing the return type to Any to accommodate functions that return different types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.