Solution #1455
Solution #1455
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets the task requirements and works as expected. Just a couple of things to keep in mind for future improvements: ensure that arguments used as keys in the cache are hashable, and consider aligning the return type annotation of the wrapper function with the function it wraps. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| pass | ||
| cache_store = {} | ||
|
|
||
| def wrapper(*args: tuple) -> Callable: |
There was a problem hiding this comment.
The return type annotation for the wrapper function should be the same as the return type of the func it wraps, not Callable. Consider changing it to match the return type of func.
| cache_store = {} | ||
|
|
||
| def wrapper(*args: tuple) -> Callable: | ||
| if args in cache_store: |
There was a problem hiding this comment.
Using mutable types like lists or dictionaries as keys in a dictionary will raise a TypeError. Ensure that the arguments passed to the function are hashable, or consider converting them to a hashable type before using them as keys.
No description provided.