Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1458

Closed
wants to merge 1 commit into from
Closed

Solution #1458

wants to merge 1 commit into from

Conversation

YaroslavK87
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on implementing the cache decorator! 🎉 Your solution meets most of the task requirements and constraints, and it's great to see that it correctly handles caching and prints the expected messages. However, there's a critical issue with the return type of the wrapper function. It's currently specified as None, which is incorrect since the function is expected to return a value. Please update the return type to match the expected return type of the decorated function to ensure the decorator functions properly. Once this is addressed, your solution will be ready for approval. Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

pass
data = {}

def wrapper(*args) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type of the wrapper function is specified as None, which is incorrect. The wrapper function should return the result of the func call, so the return type should match the return type of func. Consider changing the return type to match the expected return type of the decorated function.

@YaroslavK87 YaroslavK87 deleted the develop branch December 17, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants