easy #1461
easy #1461
Conversation
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 The code meets the task requirements and functions correctly. Just a couple of things to keep in mind: ensure your Python environment supports the type annotations you're using, and remember to use immutable types for cache keys to avoid potential issues. Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| @wraps(func) | ||
| def wrapper(*args: Any) -> Any: | ||
| if args in func_cache: |
There was a problem hiding this comment.
Using mutable types like lists or dictionaries as keys in a dictionary will raise a TypeError because they are not hashable. Ensure that the arguments used as keys in func_cache are immutable. Consider converting mutable arguments to immutable types, such as tuples, before using them as keys.
|
|
||
|
|
||
| @cache | ||
| def long_time_func_2(numbers: Tuple[int, ...], power: int) -> list[int]: |
There was a problem hiding this comment.
The function long_time_func_2 returns a list, but the return type annotation specifies list[int], which is correct for Python 3.9 and above. Ensure that your Python environment supports this syntax, or use List[int] with an appropriate import from typing for compatibility with earlier versions.
No description provided.