Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1497

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Solution
Liliia Plotnikova authored and Liliia Plotnikova committed Jan 18, 2025
commit faf7a24f7066da39c775657fa95438b58601cb04
13 changes: 6 additions & 7 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
from typing import Callable


def cache(func: Callable) -> Callable:
dict_funcs = {}

def inner(*args) -> Callable:
def cache(func: Callable, **dict_funcs) -> Callable:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dict_funcs parameter should not be part of the cache function signature. Instead, initialize dict_funcs as an empty dictionary inside the inner function to ensure each decorated function has its own cache.

def inner(*args, **dict_of_element) -> Callable:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove dict_of_element from the parameters of the inner function as it is not needed. You can define it within the function body.

str_func = " ".join(str(val) for val in args)
if str_func in dict_funcs.keys():
print("Getting from cache")
return dict_funcs[str_func]
else:
dict_funcs.update({str_func : func(*args)})
dict_of_element = {str_func : func(*args)}
dict_funcs.update(dict_of_element)
print("Calculating new result")

return dict_funcs[str_func]
return dict_of_element[str_func]
return inner
Loading