solution py-cache-decorator #1500
Conversation
There was a problem hiding this comment.
Great job on implementing the caching mechanism! 🎉 The code meets the task requirements and constraints effectively. Just a couple of minor suggestions: consider returning a tuple instead of a list in long_time_func_2 to ensure immutability, and update the return type hint for wrapper to Any. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
app/main.py
Outdated
| cache_storage = {} | ||
|
|
||
| @wraps(func) | ||
| def wrapper(*args) -> Callable: |
There was a problem hiding this comment.
The return type hint for wrapper should be Any instead of Callable since it returns the result of the decorated function, which can be of any type.
app/main.py
Outdated
|
|
||
|
|
||
| @cache | ||
| def long_time_func_2(n_tuple: tuple, power: int) -> Any: |
There was a problem hiding this comment.
The long_time_func_2 function returns a list, which is mutable. This contradicts the cache's requirement for immutable argument types. Consider returning a tuple instead of a list to ensure immutability.
No description provided.