Solution #1512
Open
Solution #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Great job on implementing the caching decorator! 🎉 Your code meets the task requirements and works well with immutable arguments. Just a small tip: be cautious with mutable arguments as dictionary keys, as they can cause issues. Consider converting them to immutable types if needed. Keep up the great work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| @wraps(func) | ||
| def wrapper(*args) -> Any: | ||
| if args in dict_results: |
There was a problem hiding this comment.
Using args as a dictionary key can lead to issues if any of the arguments are mutable (e.g., lists). Mutable objects are not hashable and cannot be used as dictionary keys. Consider converting args to a tuple of immutable types if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.