-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #649
Closed
Closed
Solution #649
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
850068b
Solution
Daniil-Pankieiev 0751590
Solution
Daniil-Pankieiev 28e93de
Solution
Daniil-Pankieiev 455440b
Merge branch 'master' into develop
Daniil-Pankieiev 5627018
Solution
Daniil-Pankieiev f37bc86
Merge remote-tracking branch 'origin/develop' into develop
Daniil-Pankieiev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,19 @@ | ||
def cache(func): | ||
# Write your code here | ||
pass | ||
from typing import Callable | ||
from typing import Any | ||
|
||
|
||
def cache(func: Callable) -> Callable: | ||
cached_results = {} | ||
|
||
def wrapper(*args) -> Any: | ||
key = args | ||
if key in cached_results: | ||
print("Getting from cache") | ||
return cached_results[key] | ||
else: | ||
result = func(*args) | ||
cached_results[key] = result | ||
print("Calculating new result") | ||
return result | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can use a single return statement out of the if/else statement instead of two inside it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed. Thanks it really looks better |
||
|
||
return wrapper |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really needed to create new variable here
Also, you can name the parameters in a function definition as you like, but it's a common convention to use
*args
. So,args
will fit good here 👍