Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #649

Closed
wants to merge 6 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
def cache(func):
# Write your code here
pass
from typing import Callable
from typing import Any


def cache(func: Callable) -> Callable:
cached_results = {}

def wrapper(*args) -> Any:
key = args

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really needed to create new variable here
Also, you can name the parameters in a function definition as you like, but it's a common convention to use *args. So, args will fit good here 👍

if key in cached_results:
print("Getting from cache")
return cached_results[key]
else:
result = func(*args)
cached_results[key] = result
print("Calculating new result")
return result

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use a single return statement out of the if/else statement instead of two inside it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks it really looks better


return wrapper