Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #705

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

'Solution' #705

wants to merge 3 commits into from

Conversation

Prorochenkko
Copy link

No description provided.

app/main.py Outdated
result = func(*args, **kwargs)
result_cache[key] = result
print("Calculating new result")
return result

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to use only one return

app/main.py Outdated
result_cache[key] = result
print("Calculating new result")

return result

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return result
return result_cache[key]

app/main.py Outdated
print("Getting from cache")
result = result_cache[key]
else:
result = func(*args, **kwargs)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
result = func(*args, **kwargs)
result_cache[key] = func(*args, **kwargs)

app/main.py Outdated

if key in result_cache:
print("Getting from cache")
result = result_cache[key]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and delete this

app/main.py Outdated
result = result_cache[key]
else:
result = func(*args, **kwargs)
result_cache[key] = result

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants