Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done tache cache_decorator #706

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

OlenaLis123
Copy link

No description provided.

Copy link

@YukihiroSM YukihiroSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests, please.

Copy link

@EdAlekseiev EdAlekseiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests, please

@OlenaLis123
Copy link
Author

Добрий день , в мене в PyCharm всі тести проходять , може була помилка бо був конфлікт , я його спробувала порішати , вибачте , я щось тут нічого не розумію , є якийсь урок по реквестам для чайників початківців ? ((

app/main.py Outdated
if tuple_parames in store_result.keys():
print("Getting from cache")
return store_result[tuple_parames]
else:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove redundant 'else'

app/main.py Outdated
Comment on lines 15 to 24


@cache
def long_time_func(num_1: int, num_2: int, num_3: int) -> int:
return (num_1 ** num_2 ** num_3) % (num_1 * num_3)


@cache
def long_time_func_2(n_tuple: tuple, power: int) -> list:
return [number ** power for number in n_tuple]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these test functions

Copy link

@EdAlekseiev EdAlekseiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants