Cache decorator solution #730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykolamateichuk
suggested changes
Sep 28, 2023
app/main.py
Outdated
| pass | ||
| stored_runs = {} | ||
|
|
||
| def wrapper(*args) -> int: |
There was a problem hiding this comment.
You can't always guarantee that the function you run will return int type.
|
In my opinion, for more readable code it's nice to use one return with the ternary operator in wrapper(). |
Shatrovskyi
approved these changes
Sep 29, 2023
LiudmylaKulinchenko
suggested changes
Oct 13, 2023
app/main.py
Outdated
| print("Getting from cache") | ||
| return stored_runs[args] | ||
| print("Calculating new result") | ||
| stored_runs.update({args: func(*args)}) |
There was a problem hiding this comment.
Use stored_runs[args] = func(*args), your approach introduces unnecessary complexity without any significant advantage. Also it will be more pythonic
app/main.py
Outdated
| def wrapper(*args) -> Any: | ||
| if args in stored_runs: | ||
| print("Getting from cache") | ||
| return stored_runs[args] |
There was a problem hiding this comment.
Rewrite without having return duplicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.