Solution #731
Open
Solution #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naz-iv
approved these changes
Sep 29, 2023
Thank you! Yeah, when I realized that creating a variable in line 8 was redundant it was already too late ))) The pull request had been done ) |
MiskoRuslan
reviewed
Sep 29, 2023
app/main.py
Outdated
| cache_dict = {} | ||
|
|
||
| def inner(*args, **kwargs) -> None: | ||
| key = args |
There was a problem hiding this comment.
indeed, on line 8 you can do without "key"
There was a problem hiding this comment.
Yeah, it was a silly thing ))) Goin' to correct ;)
MiskoRuslan
reviewed
Sep 29, 2023
| if key in cache_dict: | ||
| print("Getting from cache") | ||
| return cache_dict[key] | ||
| else: |
There was a problem hiding this comment.
you can try to do without "else"
MiskoRuslan
suggested changes
Sep 29, 2023
LiudmylaKulinchenko
suggested changes
Oct 2, 2023
| print("Calculating new result") | ||
| cache_dict[args] = func(*args, **kwargs) | ||
|
|
||
| return cache_dict[args] |
There was a problem hiding this comment.
try to rewrite your decorator not to have return duplicated
app/main.py
Outdated
| pass | ||
| cache_dict = {} | ||
|
|
||
| def inner(*args, **kwargs) -> [list, int]: |
There was a problem hiding this comment.
inner can return not only that types, it's better to use Any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO, Decorators is a very hard topic to comprehend... ) Solving this task, I thought It was over my head