Solution #739
Open
Solution #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsocie7y
suggested changes
Sep 29, 2023
app/main.py
Outdated
| pass | ||
| cached = {} | ||
|
|
||
| def inner(*args, **kwargs) -> None: |
There was a problem hiding this comment.
it's better to use Any for return type annotation in this case
app/main.py
Outdated
| cached = {} | ||
|
|
||
| def inner(*args, **kwargs) -> None: | ||
| if args in cached.keys(): |
There was a problem hiding this comment.
no need to use keys() method here, it will search through keys by default
in similar case too
fsocie7y
suggested changes
Sep 29, 2023
app/main.py
Outdated
| cached[args] = new_cache | ||
| print("Calculating new result") | ||
|
|
||
| return func(*args) if args not in cached.keys() else cached[args] |
app/main.py
Outdated
| cached[args] = new_cache | ||
| print("Calculating new result") | ||
|
|
||
| return func(*args) if args not in cached.keys() else cached[args] |
There was a problem hiding this comment.
and may be better use just one if else statment
There was a problem hiding this comment.
If I replace one if statement, inner() is going to have two returns, isn't it? It's not good as well.
There was a problem hiding this comment.
I've found out how to deal with that. Now It looks better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.