Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #743

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,19 @@


def cache(func: Callable) -> Callable:
# Write your code here
pass
from functools import wraps

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you make this import here?

cached_results = {}

@wraps(func)
def wrapper(*args, **kwargs) -> int:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type could be Any because the output of the wrapped function is not known in advance to the decorator.

key = (args, frozenset(kwargs.items()))
if key in cached_results:
print("Getting from cache")
return cached_results[key]
else:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove redundant else

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redundant else should be removed, code will not execute after the return statement anyway.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

якщо я видаляю еlse то не проходять тести

result = func(*args, **kwargs)
cached_results[key] = result
print("Calculating new result")
return result

return wrapper
Loading