Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The decorator "cache" is created, tested and ready to work #745

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

The decorator "cache" is created, tested and ready to work #745

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
632f0f5
The decorator "cache" is created, tested and ready to work
Moonralex Sep 29, 2023
fe67f54
Removed unnecessary "else", and docstring
Moonralex Sep 30, 2023
8def249
Removed redundant code.
Moonralex Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
from typing import Callable
from typing import Callable, Any


def cache(func: Callable) -> Callable:
# Write your code here
pass
cached_data = {}

def argument_based_cacher(*args) -> Any:
if func.__name__ not in cached_data.keys():
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use decorator from functools to preserve the wrapped function naming and docstring.

cached_data[func.__name__] = {}
if args in cached_data[func.__name__]:
print("Getting from cache")
return cached_data[func.__name__][args]
print("Calculating new result")
func_result = func(*args)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decorator cache is supposed to decorate only functions that take immutable arguments.

cached_data[func.__name__][args] = func_result
return func_result
return argument_based_cacher
Loading