Solution #746
Open
Solution #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiudmylaKulinchenko
suggested changes
Oct 2, 2023
app/main.py
Outdated
| pass | ||
| cache_dict = {} | ||
|
|
||
| def inner(*args: tuple) -> [list, int]: |
There was a problem hiding this comment.
Yes, inner can return not only these types, it's better to use Any
app/main.py
Outdated
| pass | ||
| cache_dict = {} | ||
|
|
||
| def inner(*args: tuple) -> [list, int]: |
There was a problem hiding this comment.
No need to add type annotations to *args. You can use, for example, *args: int if you want to indicate that func expects integer arguments
Fix not correct type anotation
fsocie7y
suggested changes
Oct 2, 2023
app/main.py
Outdated
| if args not in cache_dict: | ||
| cache_dict[args] = func(*args) | ||
| print("Calculating new result") | ||
| return cache_dict[args] |
There was a problem hiding this comment.
try to rewrite your decorator not to have return duplicated
use only one 'return'
DenPrislipskyi
approved these changes
Oct 3, 2023
DenPrislipskyi
approved these changes
Oct 4, 2023
Oxbay
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel a little problem on the seventh line :))
But let`s try