Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #754

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #754

wants to merge 2 commits into from

Conversation

katyakoziar
Copy link

No description provided.

app/main.py Outdated


def cache(func: Callable) -> Callable:
# Write your code here
pass
results_of_function_runs = {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use shorter name

app/main.py Outdated
Comment on lines 9 to 12
result = func(*args)
results_of_function_runs[args] = result
print("Calculating new result")
return result

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to avoid using additional result variable here

app/main.py Outdated
return result
else:
print("Getting from cache")
return results_of_function_runs[args]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also try not to have return duplicated

Copy link

@fsocie7y fsocie7y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants