-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completed task #1598
base: master
Are you sure you want to change the base?
completed task #1598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you've done a great job implementing most of the classes and methods according to the task requirements! 🎉 However, there's a small but critical issue in the main.py
file where the movie_session
method is being called incorrectly. Please change CinemaHall.movie_session(...)
to cinema_hall_instance.movie_session(...)
to ensure the code functions as intended. Once this is fixed, your solution will be ready to go! Keep up the great work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
CinemaHall.movie_session(cinema_hall_instance, movie, | ||
customer_instances, cleaner_instance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The movie_session
method should be called on the cinema_hall_instance
object, not directly on the CinemaHall
class. Change CinemaHall.movie_session(...)
to cinema_hall_instance.movie_session(...)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great job on implementing the required classes and methods according to the task description! 🎉 Your solution is almost complete, but there's a critical issue in the main.py
file that needs attention:
- Critical Issue: The
movie_session
method of theCinemaHall
class is being called incorrectly. It should be called on thecinema_hall_instance
object, not directly on theCinemaHall
class. Please change:to:CinemaHall.movie_session(cinema_hall_instance, movie, customer_instances, cleaner_instance)
cinema_hall_instance.movie_session(movie, customer_instances, cleaner_instance)
This change is crucial for the code to function as intended.
All other files and implementations meet the task requirements and constraints. Keep up the good work! Remember, addressing such issues will help you improve your coding skills and avoid similar problems in the future. Keep learning and refining your skills! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
CinemaHall.movie_session(cinema_hall_instance, movie, | ||
customer_instances, cleaner_instance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The movie_session
method should be called on the cinema_hall_instance
object, not directly on the CinemaHall
class. Change CinemaHall.movie_session(...)
to cinema_hall_instance.movie_session(...)
.
No description provided.