Solution #1637
Solution #1637
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class with all the required functionalities! 🎉 Your code is clear and adheres to Python conventions. Just a small note: for broader compatibility with Python versions earlier than 3.10, consider using Union[Distance, int, float] instead of Distance | int | float for type hints. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: "Distance | int | float") -> "Distance": |
There was a problem hiding this comment.
The type hint Distance | int | float is not valid in Python versions before 3.10. If you need compatibility with earlier versions, consider using Union[Distance, int, float] from the typing module.
| return Distance(self.km + other) | ||
| return NotImplemented | ||
|
|
||
| def __iadd__(self, other: "Distance | int | float") -> "Distance": |
There was a problem hiding this comment.
Similar to the previous comment, the type hint Distance | int | float requires Python 3.10 or later. For earlier versions, use Union[Distance, int, float].
| return NotImplemented | ||
| return self | ||
|
|
||
| def __mul__(self, factor: "int | float") -> "Distance": |
There was a problem hiding this comment.
The type hint int | float is only valid in Python 3.10 and later. For compatibility with earlier versions, use Union[int, float].
| return Distance(self.km * factor) | ||
| return NotImplemented | ||
|
|
||
| def __truediv__(self, divisor: "int | float") -> "Distance": |
There was a problem hiding this comment.
The type hint int | float is only valid in Python 3.10 and later. For compatibility with earlier versions, use Union[int, float].
| return Distance(round(self.km / divisor, 2)) | ||
| return NotImplemented | ||
|
|
||
| def __lt__(self, other: "Distance | int | float") -> bool: |
There was a problem hiding this comment.
The type hint Distance | int | float is only valid in Python 3.10 and later. For compatibility with earlier versions, use Union[Distance, int, float].
| return self.km < other | ||
| return NotImplemented | ||
|
|
||
| def __gt__(self, other: "Distance | int | float") -> bool: |
There was a problem hiding this comment.
The type hint Distance | int | float is only valid in Python 3.10 and later. For compatibility with earlier versions, use Union[Distance, int, float].
| return self.km > other | ||
| return NotImplemented | ||
|
|
||
| def __eq__(self, other: "Distance | int | float") -> bool: |
There was a problem hiding this comment.
The type hint Distance | int | float is only valid in Python 3.10 and later. For compatibility with earlier versions, use Union[Distance, int, float].
| return self.km == other | ||
| return NotImplemented | ||
|
|
||
| def __le__(self, other: "Distance | int | float") -> bool: |
There was a problem hiding this comment.
The type hint Distance | int | float is only valid in Python 3.10 and later. For compatibility with earlier versions, use Union[Distance, int, float].
| def __le__(self, other: "Distance | int | float") -> bool: | ||
| return self < other or self == other | ||
|
|
||
| def __ge__(self, other: "Distance | int | float") -> bool: |
There was a problem hiding this comment.
The type hint Distance | int | float is only valid in Python 3.10 and later. For compatibility with earlier versions, use Union[Distance, int, float].
No description provided.