Solution #1644
Solution #1644
Conversation
There was a problem hiding this comment.
Thank you for your hard work on the Distance class! There are a couple of critical issues that need to be addressed before we can approve the pull request. The __truediv__ method is returning a tuple instead of a Distance instance, which affects the functionality. Additionally, the __le__ method has a logical error as it uses != instead of <=. Once these issues are resolved, your solution will be much closer to meeting the task requirements. Keep up the great work, and don't hesitate to reach out if you need any help! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| def __truediv__(self, other): | ||
| if isinstance(other, Distance): | ||
| self.km = round(self.km / other.km, 2) | ||
| return self, 2 |
There was a problem hiding this comment.
The __truediv__ method is returning a tuple (self, 2) when dividing by another Distance object. This seems incorrect as it should return only self after performing the division. The 2 appears to be mistakenly included.
|
|
||
| def __le__(self, other): | ||
| if isinstance(other, Distance): | ||
| return self.km != other.km |
There was a problem hiding this comment.
The __le__ method is using != instead of <=. This is a logical error as __le__ should implement the 'less than or equal to' comparison, not 'not equal to'.
| if isinstance(other, Distance): | ||
| return self.km != other.km | ||
| elif isinstance(other, int): | ||
| return self.km != other |
There was a problem hiding this comment.
Similar to the previous comment, the __le__ method should use <= instead of != for comparing with an integer.
No description provided.