Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #346

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Solution #346

wants to merge 7 commits into from

Conversation

prochigor
Copy link

No description provided.

mykolamateichuk
mykolamateichuk approved these changes Dec 6, 2023
View reviewed changes
Copy link

@mykolamateichuk mykolamateichuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Y-Havryliv
Y-Havryliv suggested changes Dec 7, 2023
View reviewed changes
Copy link

@Y-Havryliv Y-Havryliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, you were supposed to change README.md.
You must modify this line with correct command to pull your image: COMMAND=docker pull <YOUR_DOCKER_ID/YOUR_IMAGE_NAME>.

app/main.py Outdated

URL = "http://api.weatherapi.com/v1/current.json"
FILTERING = "Paris"
API_KEY = os.environ["API_KEY"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the env variable is not found, your code will break

app/main.py
"key": API_KEY
}

response = requests.get(URL, params=params)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to print: Performing request to Weather API for city Paris...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykolamateichuk mykolamateichuk mykolamateichuk approved these changes

@Y-Havryliv Y-Havryliv Y-Havryliv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prochigor @mykolamateichuk @Y-Havryliv