Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker complete #357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Sel-Fisher
Copy link

No description provided.

# write your code here
pass
print(f"Performing request to Weather API for city {CITY}...")
response = requests.get(URL + f"?key={API_KEY}&q={CITY}")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's not in the checklist, but it's better to create params variable with key and q and then do:

requests.get(URL, params=params)

print(f"Performing request to Weather API for city {CITY}...")
response = requests.get(URL + f"?key={API_KEY}&q={CITY}")
weather_data = response.json()
if weather_data:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, you can receive not 200 status code, and then your code will break)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants