Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #691

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

A-n-a-s-t-a-s-i-i-a
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request:

  1. Dockerfile Issues:

    • There's a typo in the environment variable name. It should be PYTHONUNBUFFERED instead of PYTHOUNNBUFFERED.
    • The WORKDIR should not end with a slash. Please change it to WORKDIR app instead of WORKDIR app/.
  2. Code Improvement:

    • In main.py, the days parameter is not needed for the current weather API endpoint. Removing it will help avoid confusion and potential errors.

Once these issues are resolved, your code will be in great shape! Keep up the good work, and feel free to reach out if you have any questions or need further assistance. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on addressing most of the previous issues! 🎉 Your .dockerignore and main.py files are well-configured, and the Docker image is based on a slim version, which is excellent for efficiency. However, there's a small tweak needed in your Dockerfile: the CMD instruction should be corrected to CMD ["python", "main.py"] to ensure the service runs correctly.

Remember, addressing this will help your application function as intended. Keep up the good work, and continue learning from these experiences. Your progress is impressive, and I'm confident you'll nail these details in no time! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants