implement py-elves-and-dwarves #1349
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 The code is well-structured and meets all the core functionalities. There's just a minor typo in the DwarfWarrior class where hummer_level should be hammer_level. It's a small change, but correcting it will improve clarity and consistency. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __init__(self, | ||
| nickname: str, | ||
| favourite_dish: str, | ||
| hummer_level: int |
There was a problem hiding this comment.
There seems to be a typo in the parameter name hummer_level. It should likely be hammer_level to accurately describe the attribute related to a warrior's hammer.
| hummer_level: int | ||
| ) -> None: | ||
| super().__init__(nickname, favourite_dish) | ||
| self._hummer_level = hummer_level |
There was a problem hiding this comment.
Consider renaming _hummer_level to _hammer_level to correct the typo and maintain consistency with the intended attribute name.
|
|
||
| def player_info(self) -> str: | ||
| return (f"Dwarf warrior {self.nickname}." | ||
| f" {self.nickname} has a hummer of the" |
There was a problem hiding this comment.
The word 'hummer' should likely be 'hammer' in the string to accurately describe the warrior's equipment.
No description provided.