solution #1357
solution #1357
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 While there are a few minor issues, such as the naming inconsistency and the abstract methods containing implementations, these do not significantly impact the functionality of your code. Keep up the good work, and consider addressing these points to enhance your code quality even further. Happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| elf.play_elf_song() | ||
|
|
||
|
|
||
| def feast_of_the_dwarves(dwarfs: list) -> None: |
There was a problem hiding this comment.
The parameter name dwarfs should be dwarves to match the task description and maintain consistency with the naming convention used elsewhere in the code.
app/players/dwarves/dwarf.py
Outdated
| self._favourite_dish = favourite_dish | ||
|
|
||
| @abstractmethod | ||
| def eat_favourite_dish(self): |
There was a problem hiding this comment.
The eat_favourite_dish method is marked as abstract but contains an implementation. Abstract methods should not have implementations in abstract classes. Consider removing the implementation from this method.
app/players/elves/elf.py
Outdated
| self._musical_instrument = musical_instrument | ||
|
|
||
| @abstractmethod | ||
| def play_elf_song(self): |
There was a problem hiding this comment.
The play_elf_song method is marked as abstract but contains an implementation. Abstract methods should not have implementations in abstract classes. Consider removing the implementation from this method.
No description provided.