Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1359

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

'Solution' #1359

wants to merge 2 commits into from

Conversation

nagafochfv
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 There are a couple of critical issues that need to be addressed before we can approve the pull request. Specifically, the methods play_elf_song and eat_favourite_dish should be called on instances of Elf and Dwarf, respectively, rather than on the classes themselves. This change is essential for the functions elves_concert and feast_of_the_dwarves to work as intended. Once these issues are resolved, your code will be in great shape! Keep up the great work, and don't hesitate to reach out if you need any help. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your Pull Request has been approved! 🎉

Review Summary:

Your solution has successfully addressed the previous issues, particularly with the play_elf_song and eat_favourite_dish methods. Here's a brief overview of the key points:

  • Functionality: The calculate_team_total_rating, elves_concert, and feast_of_the_dwarves functions are correctly implemented, ensuring proper interaction with Elf and Dwarf instances.

  • Class Implementations: The ElfRanger, Druid, DwarfWarrior, and DwarfBlacksmith classes are well-structured, with correctly defined methods and attributes. The Elf and Dwarf classes also implement their respective methods accurately.

  • Project Structure: Your project follows the specified hierarchy and includes all necessary files, meeting the task requirements and constraints.

While your code is approved, it's important to continuously review and improve your code based on feedback. This will help you avoid similar issues in the future and enhance your coding skills. Keep up the great work, and continue learning from each experience! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants