Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all tests passed. flake8 passed #1366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

all tests passed. flake8 passed #1366

wants to merge 1 commit into from

Conversation

Mykola-Osolinskyi
Copy link

No description provided.

Nattalli
Nattalli approved these changes Jan 3, 2025
View reviewed changes
Copy link

@Nattalli Nattalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, small comments left

app/main.py


def elves_concert(elfs: list[Elf]) -> None:
for elf in elfs:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elfs - is incorrect, look at the function name

app/main.py


def feast_of_the_dwarves(dwarfs: list[Dwarf]) -> None:
for dwarf in dwarfs:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nattalli Nattalli Nattalli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mykola-Osolinskyi @Nattalli