Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test solution sent via git bash #1407

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,20 @@
# write your code here
from typing import List
from app.players.elves.elf_ranger import ElfRanger
from app.players.dwarves.dwarf_warrior import DwarfWarrior


def calculate_team_total_rating(players: List[object]) -> int:
total_rating = 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calculate_team_total_rating function should accept a list of Player objects, not object. Update the type hint to List[Player] to reflect this requirement.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calculate_team_total_rating function should take a list of Player objects, not object. Update the type hint to List[Player] to reflect this requirement.

for player in players:
total_rating += player.get_rating()
return total_rating


def elves_concert(elves: List[ElfRanger]) -> None:
for elf in elves:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The elves_concert function should accept a list of Elf objects, not just ElfRanger. Update the type hint to List[Elf] to ensure it works with all elf subclasses.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The elves_concert function should accept a list of Elf objects, not just ElfRanger. Update the type hint to List[Elf] to align with the task requirements.

elf.play_elf_song()


def feast_of_the_dwarves(dwarves: List[DwarfWarrior]) -> None:
for dwarf in dwarves:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feast_of_the_dwarves function should accept a list of Dwarf objects, not just DwarfWarrior. Update the type hint to List[Dwarf] to ensure it works with all dwarf subclasses.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feast_of_the_dwarves function should accept a list of Dwarf objects, not just DwarfWarrior. Update the type hint to List[Dwarf] to align with the task requirements.

dwarf.eat_favourite_dish()
10 changes: 10 additions & 0 deletions app/players/dwarves/dwarf.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from app.players.player import Player


class Dwarf(Player):
def __init__(self, nickname: str, favourite_dish: str) -> None:
super().__init__(nickname)
self._favourite_dish = favourite_dish

def eat_favourite_dish(self) -> None:
print(f"{self.nickname} is eating {self._favourite_dish}")
16 changes: 16 additions & 0 deletions app/players/dwarves/dwarf_blacksmith.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
from app.players.dwarves.dwarf import Dwarf


class DwarfBlacksmith(Dwarf):
def __init__(self, nickname: str,
favourite_dish: str,
skill_level: int) -> None:
super().__init__(nickname, favourite_dish)
self._skill_level = skill_level

def get_rating(self) -> int:
return self._skill_level

def player_info(self) -> str:
return (f"Dwarf blacksmith {self.nickname} "
f"with skill of the {self._skill_level} level")
17 changes: 17 additions & 0 deletions app/players/dwarves/dwarf_warrior.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
from app.players.dwarves.dwarf import Dwarf


class DwarfWarrior(Dwarf):
def __init__(self, nickname: str,
favourite_dish: str,
hummer_level: int) -> None:
super().__init__(nickname, favourite_dish)
self._hummer_level = hummer_level

def get_rating(self) -> int:
return self._hummer_level + 4

def player_info(self) -> str:
return (f"Dwarf warrior {self.nickname}. "
f"{self.nickname} has a hummer of "
f"the {self._hummer_level} level")
17 changes: 17 additions & 0 deletions app/players/elves/druid.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
from app.players.elves.elf import Elf


class Druid(Elf):
def __init__(self, nickname: str,
musical_instrument: str,
favourite_spell: str) -> None:
super().__init__(nickname, musical_instrument)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the Elf class constructor accepts musical_instrument as a parameter. If not, adjust the super().__init__ call accordingly.

self._favourite_spell = favourite_spell

def get_rating(self) -> int:
return len(self._favourite_spell)

def player_info(self) -> str:
return (f"Druid {self.nickname}. "
f"{self.nickname} has a favourite spell: "
f"{self._favourite_spell}")
11 changes: 11 additions & 0 deletions app/players/elves/elf.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
from app.players.player import Player


class Elf(Player):
def __init__(self, nickname: str, musical_instrument: str) -> None:
super().__init__(nickname)
self._musical_instrument = musical_instrument

def play_elf_song(self) -> None:
print(f"{self.nickname} is playing a song on the "
f"{self._musical_instrument}")
16 changes: 16 additions & 0 deletions app/players/elves/elf_ranger.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
from app.players.elves.elf import Elf


class ElfRanger(Elf):
def __init__(self, nickname: str,
musical_instrument: str,
bow_level: int) -> None:
super().__init__(nickname, musical_instrument)
self._bow_level = bow_level

def get_rating(self) -> int:
return 3 * self._bow_level

def player_info(self) -> str:
return (f"Elf ranger {self.nickname}. "
f"{self.nickname} has bow of the {self._bow_level} level")
14 changes: 14 additions & 0 deletions app/players/player.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from abc import ABC, abstractmethod


class Player(ABC):
def __init__(self, nickname: str) -> None:
self.nickname = nickname

@abstractmethod
def get_rating(self) -> int:
pass

@abstractmethod
def player_info(self) -> str:
pass
Loading