implement #1418
implement #1418
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While your implementation of the functions in app/main.py is spot on, there's a critical issue that needs to be addressed before we can approve the pull request. The task description specifies a project structure that includes several class definition files such as player.py, elf.py, elf_ranger.py, druid.py, dwarf.py, dwarf_warrior.py, and dwarf_blacksmith.py. These files are missing, and they are essential for the task as they contain the class definitions required for your functions to operate correctly. Please ensure these files are implemented and included in the project structure. Once that's done, we can move forward with the approval. Keep up the great work, and don't hesitate to reach out if you need any help! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
app/main.py
Outdated
| total_rating = 0 | ||
| for player in team: | ||
| total_rating += player.get_rating() | ||
| return total_rating |
There was a problem hiding this comment.
try to write it in one line, use sum(...)
No description provided.