'Solution' #415
'Solution' #415
Conversation
There was a problem hiding this comment.
Great job on implementing the CRUD operations and setting up the FastAPI application! 🎉 The code is well-structured and meets the task requirements. Just a small tweak is needed: add skip and limit parameters to the get_all_authors function in crud.py to enable pagination as intended. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| from sqlalchemy.orm import Session | ||
|
|
||
|
|
||
| def get_all_authors(db: Session): |
There was a problem hiding this comment.
The get_all_authors function should accept skip and limit parameters to support pagination, as indicated by the usage in main.py. Consider adding these parameters and using them in the query.
| @app.get("/author/", response_model=list[schemas.AuthorRead]) | ||
| def read_authors(skip: int = 0, | ||
| limit: int = 10, db: Session = Depends(get_db)): | ||
| return crud.get_all_authors(db=db, skip=skip, limit=limit) |
There was a problem hiding this comment.
The read_authors function calls crud.get_all_authors with skip and limit parameters, but these parameters are not defined in the get_all_authors function in crud.py. You should add skip and limit parameters to the get_all_authors function to support pagination.
No description provided.